Problem adding "exit" bitmapbutton

Replying to lalong1@bellsouth.net:

I am trying to build a simple toolbar, but when I add the "exit" bitmapbutton the class stop working. I think it may be because something that parses the xml file may not like the text "exit" showing up(??). The reason I think so is if I change the same object to use another bitmap button it starts working after I exit and re-enter dabo. Can someone verify the issue? Below is a copy of the cdxml file. To duplicate, load the file and run it first. It should run. Then change the "copy" button to the "exit" and re-try.

Can you post that as an attachment? The wiki formatting messes it up too much to test.

My Environment is:

Platform: Win Python Version: 2.5 on win32 Dabo Version: Version 0.7.2s; Revision 2719 UI Version: 2.8.1.1 on wxMSW Dabo IDE version 0.7.1s (Revision 755)

It looks like the problem has got nothing to do wit the toolbar. I start the ClassDesigner?, insert one bitmapbutton there, rename it to be 'exit' and run. Here's the result:

===================================================== Traceback (most recent call last):

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\lib\eventMixin.

py", line 97, in raiseEvent

bindingFunction(event)

File "C:\Python\Dabo\daboide\ClassDesigner?.py", line 1294, in onRunDesign

self.currentForm.onRunDesign(evt)

File "C:\Python\Dabo\daboide\ClassDesignerFormMixin?.py", line 493, in onRunDes

ign

frm = dui.createForm(self._classFile)

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\ui\uiwx\init_

_.py", line 836, in createForm

frm = cls()

File "", line 35, in init File "", line 53, in init File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\ui\uiwx\dBitmap

Button.py", line 39, in init

cm.dControlMixin.init(self, preClass, parent, properties, *args, **kwarg

s)

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\ui\uiwx\dPemMix

in.py", line 175, in init

self._setProperties(properties)

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\ui\uiwx\dPemMix

in.py", line 208, in _setProperties

self.setProperties(properties)

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\lib\propertyHel

perMixin.py", line 186, in setProperties

_setProps(propDict)

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\lib\propertyHel

perMixin.py", line 176, in _setProps

setter(self, _propDict[prop])

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\ui\uiwx\dPemMix

in.py", line 1912, in _setNameBase

self._setName(val, False)

File "c:\python25\lib\site-packages\Dabo-0.7.2s-py2.5.egg\dabo\ui\uiwx\dPemMix

in.py", line 1852, in _setName

nameError = hasattr(parent, candidate) \

TypeError?: hasattr(): attribute name must be string =====================================================

If I change the name to be 'copy' and run, I get a dialog saying:

===================================================== Could not set property 'Name' to value 'copy'. Reason: 'Name 'copy' is already in use.' ===================================================== Maybe version differences are enough to explain the behaviour differences with 'copy' compared to the original error report.

I don't understand anything about the situation but that doesn't keep me from making a suggestion;): if certain names cause unwanted behaviour, let's just ban those names. You know: world's full of names and if the supply runs out, we all can easily invent a few thousand new ones!

Besides: copy as a name for a button is not a good one anyway: it's too general and unspecific. Better ones are copyBtn, copyRecord, doCopy etc.

Well, this was just my 2 cents' worth,

Cheers, Jussi

You can't name an object the same as any other object in the same parent container, because the parent has to be able to resolve those names. Likewise, if you try to name an object 'copy', 'exit', or any other existing attribute or method of the parent, it will likewise reject that, since that 'name' is already taken in the parent object's namespace.

You're always better off not using common words, but using specific names, such as 'btnExit' for your controls.

OK, I tracked down the problem. 'exit' is a method in the builtins module, and so eval('exit') is being called when assigning the attribute to the object. That's causing all of the problems.

I need to track down all the places where this is happening to make sure that this and any of the other built-in names don't cause similar problems.

Fixed with changeset [2989]